Adding a contract to deployment section when using flowkit.AddContract #1247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjartek
changed the title
bjartek
requested review from
Kay-Zee,
janezpodhostnik,
sideninja,
chasefleming,
nvdtf,
bluesign and
jribbink
as code owners
|
Not quite sure why my editor (nvim) deletes these lines, if you want me to i can add them back once the logic is approved. |
bjartek
added
Bug
|
@bjartek looks like tests are failing |
|
It fails because testnet is sporking |
|
@chasefleming tests should work now. |
bluesign
approved these changes
Oct 26, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1247 +/- ##
==========================================
+ Coverage 38.65% 40.79% +2.14%
==========================================
Files 38 38
Lines 1948 1978 +30
==========================================
+ Hits 753 807 +54
+ Misses 1107 1082 -25
- Partials 88 89 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
chasefleming
approved these changes
Oct 26, 2023
chasefleming
deleted the
bjartek/add-deployment-block-when-adding-contract
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1201
Description
When adding a Contract it is added to the contracts state but not to deployments if the deployment network does not exist already.
For contributor use:
masterbranchFiles changedin the Github PR explorer